Windows Ninja Builds - faster build times #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction), disable unnecessary ccache from Windows CIBW
|
Thanks @paultiq, I'm putting this on the list to dig in to. We should check whether we can do this on core before making the change here, since that's where duckdb itself is tested in excruciating depth. |
|
Thinking about this for a moment, if this is of interest, the next step should really be to do a side by side comparison of the compiler flags being passed by ninja and msbuild. There's a few differences. Alternatives for improving build time:
|
|
Will close this for now, let me know if there's interest, this was just a proof of concept. I'm seeing ~5 min builds with ninja + sccache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the 3.14 stuff, I noticed how slow the Windows builds were in GHA Runners. With some experimentation, I found enabling Ninja makes a significant impact.
This PR speeds Windows builds by enabling Ninja.
Changes to packaging_wheels.yml workflow:
Functional changes:
Impact:
edit:
CIBW_ENVIRONMENT_WINDOWS: PYTHON_GIL=1 CMAKE_BUILD_TYPE=Releaseis to exclude Jemalloc on Debug builds too... I'm not sure why it's only disabled for Release.